shim: Optionally tolerate MokManager being missing #759
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our OS does not generally have a need for MokManager therefore it is not installed or provided on the ISO. However, this prevents the OS from booting at all if there is a pending MoK request leftover from another OS (either installed on a different disk or a previous installation). Therefore, provide an option to allow continuing to boot if MokManager is missing rather than rebooting the host or exiting with an error.. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
|
IMO the existing behaviour is not a good user experience. If MokManager goes missing for whatever reason, you can't boot back into your OS to fix the problem. At least not without disabling Secure Boot, booting GRUB without Shim, etc. However, since the behaviour seems to be intentional, I haven't changed the default here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our OS does not generally have a need for MokManager therefore it is not installed or provided on the ISO. However, this prevents the OS from booting at all if there is a pending MoK request leftover from another OS (either installed on a different disk or a previous installation).
Therefore, provide an option to allow continuing to boot if MokManager is missing rather than rebooting the host or exiting with an error..