Skip to content

fix: remove default value for logging as it affects other plugins #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented May 30, 2025

@jgbernalp jgbernalp requested a review from a team as a code owner May 30, 2025 13:00
@jgbernalp jgbernalp requested review from simonpasquier and falox and removed request for a team May 30, 2025 13:00
@openshift-ci openshift-ci bot requested a review from machine424 May 30, 2025 13:00
Copy link

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich
Copy link
Contributor

/lgtm

@jgbernalp
Copy link
Contributor Author

/hold

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the remove-default-log-schema branch from 601672b to 1c21223 Compare May 30, 2025 13:09
@openshift-ci openshift-ci bot removed the lgtm label May 30, 2025
@jgbernalp
Copy link
Contributor Author

/unhold

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3b4a595 into rhobs:release-1.2 May 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants