feat: add perses rbac support #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
jgbernalp
force-pushed
the
perses-rbac
branch
2 times, most recently
from
f7fb589 to
6fa81ff
Compare
jgbernalp
changed the title
jgbernalp
changed the title
PeterYurkovich
force-pushed
the
perses-rbac
branch
from
b9ee517 to
b0cb9aa
Compare
PeterYurkovich
requested review from
simonpasquier and
JoaoBraveCoding
and removed request for
a team
Signed-off-by: Gabriel Bernal <gbernal@redhat.com> Signed-off-by: PeterYurkovich <pyurkovi@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
|
/lgtm |
jgbernalp
approved these changes
Jun 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to add support for Kubernetes RBAC for perses. It takes forks of the upstream projects located at rhobs/perses and rhobs/perses-operator, and targetes the go modules at them. It updates the default images to point to quay.io/openshift-observability-ui images with the new changes rather than the upstream ones. It updates the config for perses and the operator to support the new changes.