Skip to content

Fixed a bug caused by paths with spaces in Windows. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed a bug caused by paths with spaces in Windows. #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1f9704
Fixed a bug caused by paths with spaces in Windows.
nicber Oct 1, 2016
01e6dd5
Reformatted code following suggestions.
nicber Oct 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion autoload/clang_format.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ endfunction

function! clang_format#is_invalid()
if !exists('s:command_available')
if ! executable(g:clang_format#command)
" if running on windows and the path has spaces it needs to be quoted,
" but executable() get confused by the quotes, so we remove them
if has("win32") && !executable(split(g:clang_format#command, '"')[0])
return 1
elseif !has("win32") && !executable(g:clang_format#command)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Conditions of if are complicated. I think it's good to separate them to multiple if statements
  • Indentation looks collapsed
if has('win32') || has('win64')
    if !executable(split(...))
        return 1
    endif
elseif !executable(g:clang_format#command)
    return 1
endif

Copy link
Author

@nicber nicber Oct 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed these in the latest commit.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 1
endif
let s:command_available = 1
Expand Down