Tests run slow

[SoggyBottomBoy]

I've noticed tests run slow. In my tests that have a recorded duration of <1min these actually take >10min and time out.

I wrote some dummy tests that should only take a few milliseconds (50 tests x <10ms) and these took a couple of minutes making me think there is significant overhead per test.

Is there expected to be significant overhead for running individual tests?

(excluding any start up time), i.e. the above times are after the first test completes

[ricaun]

The test is running inside Revit, so all Revit limitation is applied.

What kinda of test are you running? A sample maybe?

If the 10 minutes timeout trigger probably you are doing something strange, like the test is running for ever to finish and RevitTest abort.

[SoggyBottomBoy]

Some of the tests are as simple as:

  [Test]
  public void CreatePaddedBoundingBox_ShouldReturnBoundingBoxWithCorrectDimensions()
  {
      // Arrange
      var centerPoint = new XYZ(1, 2, 3);
      var padding = 1.5;

      // Act
      var result = BoundingBoxExtensions.CreatePaddedBoundingBox(centerPoint, padding);

      // Assert
      result.Max.Should().BeEquivalentTo(new XYZ(2.5, 3.5, 4.5));
      result.Min.Should().BeEquivalentTo(new XYZ(-0.5, 0.5, 1.5));
  }

The only thing I can think is that the test project directly references the addin project. I've noticed that the addin IExternalApplication.OnStartup seems to get called when running these. I would not have expected this behavior. I guess maybe because in the addin project dlls/.addin file is copied on build, however, when running the tests I select "do not load" for this addin.

[ricaun]

If the addin is already loaded inside Revit probably the test use the already loaded assembly as reference. Usually that is a issue if is two different versions.

Strange, probably something else is calling the IExternalApplication.OnStartup, the RevitTest is not aware of any IExternalApplication. Only if you create a test to create the application and execute the OnStartup.

Only think I know could be a problem with timeout is if you are running some Async Task tests.

How long this take to run all 50 tests?

public class TestBoundingBox
{
    public BoundingBoxXYZ CreatePaddedBoundingBox(XYZ centerPoint, double padding)
    {
        var min = new XYZ(centerPoint.X - padding, centerPoint.Y - padding, centerPoint.Z - padding);
        var max = new XYZ(centerPoint.X + padding, centerPoint.Y + padding, centerPoint.Z + padding);
        return new BoundingBoxXYZ { Min = min, Max = max };
    }

    public static IEnumerable<int> Repeat = Enumerable.Range(0, 50);

    [TestCaseSource(nameof(Repeat))]
    public void Test(int i)
    {
        // Arrange
        var centerPoint = new XYZ(1, 2, 3);
        var padding = 1.5;

        // Act
        var result = CreatePaddedBoundingBox(centerPoint, padding);

        // Assert
        result.Max.IsAlmostEqualTo(new XYZ(2.5, 3.5, 4.5));
        result.Min.IsAlmostEqualTo(new XYZ(-0.5, 0.5, 1.5));
    }
}

In my case ~10 seconds, I know there is some internal delay to make sure the communication between Revit and TestAdapter does not break.

========== Test run finished: 50 Tests (50 Passed, 0 Failed, 0 Skipped) run in 10.1 sec ==========