Skip to content

Commit 9d0b70b

Browse files
Disable message acknowledgement via pull subscription
1 parent a7970ab commit 9d0b70b

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/PubSubEvent.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function handle(Message $message): void
5353
{
5454
set_time_limit(config('gcr-worker.max_execution_time'));
5555

56-
GcrQueue::acknowledge($message);
56+
// GcrQueue::acknowledge($message);
5757

5858
$this->createJob($message)->fire();
5959
}

src/Requests/PubSubEventRequest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ public function getPubSubMessage(): Message
2929

3030
$requestData['message']['data'] = base64_decode($requestData['message']['data'], true);
3131

32-
$message = new Message($requestData['message']);
33-
34-
return GcrQueue::pullFreshMessage($message);
32+
return new Message($requestData['message']);
33+
// return GcrQueue::pullFreshMessage(new Message($requestData['message']));
3534
}
3635

3736
/**

tests/Feature/PubSubEventHandlingTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public function it_can_handle_pubsub_invocation_as_expected()
3232
->assertStatus(200)
3333
->assertJsonFragment(['info' => 'The Pub/Sub queued job has completed.']);
3434

35-
GcrQueue::assertAcknowledgedMessagesCount(1);
36-
GcrQueue::assertMessageHasAcknowledged('1777817206939726');
35+
// GcrQueue::assertAcknowledgedMessagesCount(1);
36+
// GcrQueue::assertMessageHasAcknowledged('1777817206939726');
3737

3838
self::assertEquals('completed', Cache::get('dummy-job-status'));
3939
}

0 commit comments

Comments
 (0)