Skip to content

draft: building mcp server with fastapi with fastmcp #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

sixhobbits
Copy link

No description provided.

koladev32 and others added 24 commits June 5, 2025 08:49
…to draft/qa-mcp-server-with-fastapi-with-fastmcp

# Conflicts:
#	mcp/building-mcp-server-for-fastapi-with-fastmcp.mdx
…to draft/qa-mcp-server-with-fastapi-with-fastmcp

# Conflicts:
#	mcp/building-mcp-server-for-fastapi-with-fastmcp.mdx
…-with-fastmcp

qa: MCP server with fastapi with fastmcp
Edit: Building an MCP server with FastMCP and Speakeasy
Revert "Edit: Building an MCP server with FastMCP and Speakeasy"
nielthiart pushed a commit that referenced this pull request Jul 9, 2025
Co-authored-by: Chai Landau <112015853+chailandau@users.noreply.github.com>
@ritza-publishing-assistant
Copy link

https://github.com/ritza-co/speakeasy-developer-docs/blob/draft/building-mcp-server-with-fastapi-with-fastmcp/mcp/building-mcp-server-for-fastapi-with-fastmcp.mdx (

  • Frontmatter/title: (Building an MCP server for your FastAPI API with FastMCP) Inconsistent capitalization: “FastAPI API” could be simplified to “FastAPI” to avoid redundancy.
  • Paragraph 2: (Because Model Context Protocol (MCP) servers enable communication with APIs, they allow a range of possible integrations, such as placing orders using Claude or helping developers understand your API using Cursor AI.) The sentence starts with “Because” as a fragment; while conversational, it may feel incomplete.
  • Command snippet (uv environment commands): (uv venv) The instruction “uv venv” might be unclear if “uv” is not a widely recognized environment manager name.
  • Code block in mcp_server.py: (if name == "main":\n mcp.run()) The indentation uses 2 spaces rather than the conventional 4 spaces in Python.
  • Naming inconsistency: (APItizing Burgers example app vs. apitizing-burger project) The example project is referred to in two different ways, which might confuse readers.
  • FastMCP configuration example: (mcp = FastMCP.from_fastapi(..., name="Apitizer MCP Server", ...)) “Apitizer” may be a misspelling of “APItizing” or intended differently; the naming across the guide appears inconsistent.
  • JSON config snippet (claude-desktop-config.json): (the value for PYTHONPATH: "path/to/project/fastmcp-speakeasy-project/base/") Using a placeholder “path/to/project” may lead to confusion; consider ensuring that paths are consistent with earlier instructions.
  • Speakeasy CLI installation snippet (Windows Installation): (# Using winget:\nwinget install speakeasy) The comment is missing capitalization for “Using”—consistency with other comments (e.g. “# Homebrew (macOS)”) would improve clarity.
  • YAML overlay snippet: (target: $.paths.*["post","head","query"]) The inline array in the key might benefit from consistent spacing after commas, e.g. ["post", "head", "query"].
  • Inconsistent tool naming conventions: (McpBurgerSDK vs. mcp_server vs. Apitizer MCP Server) Different naming styles (camel case, snake case, title case) might be confusing if they refer to the same concept or related components.
  • Callout formatting: (e.g., in the Note callouts) In some callouts, HTML bold tags () are used alongside Markdown formatting; using one consistent style would be clearer.

)

…-patch-1

Revert "Revert "Edit: Building an MCP server with FastMCP and Speakeasy""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants