Skip to content

Conversation

R1j1t
Copy link

@R1j1t R1j1t commented Aug 19, 2025

These changes add Kestrel (NREL) specific build files. Not sure if there is any test files which can be added.
@rk-lindsey @nirgoldman

  • Requested develop as target branch
  • Attached test suite log file
  • Alerted reviewers if edits impact CMake or Makefile files

@R1j1t R1j1t requested a review from rk-lindsey as a code owner August 19, 2025 01:08
@rk-lindsey
Copy link
Owner

Hi @R1j1t, this PR generally looks good. However, we've recently updated our repository to use a more modern version of LAMMPS.

Hence, please update your fork (see the screenshot below) to get the latest changes and confirm that:

  • There are no merge conflicts
  • The makefile/install.sh edits work as expected.
Screenshot 2025-08-26 at 11 02 55 AM

@R1j1t
Copy link
Author

R1j1t commented Aug 26, 2025

Thanks @rk-lindsey for reviewing the PR. I am excited for the new release, and will update my branch by next week. Currently I am trying to make intel modules work, which are apparently faster than mpich.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants