Skip to content

Commit df03c36

Browse files
committed
Exclude pre-existing fibers from test
1 parent a888e55 commit df03c36

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

spec/graphql/dataloader_spec.rb

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -984,21 +984,28 @@ def self.included(child_class)
984984
query_str << "\n}"
985985
GC.start
986986
GC.disable
987+
old_fibers = []
988+
ObjectSpace.each_object(Fiber) do |f|
989+
old_fibers << f
990+
end
987991
res = schema.execute(query_str)
988992
assert_equal fields, res["data"].keys.size
989993
all_fibers = []
990994
ObjectSpace.each_object(Fiber) do |f|
991995
all_fibers << f
992996
end
993-
all_fibers.delete(Fiber.current)
994-
if all_fibers.any?(&:alive?)
995-
puts <<~ERR
996-
Alive fibers:
997-
998-
- #{all_fibers.select(&:alive?).join("\n - ")}
999-
ERR
997+
new_fibers = all_fibers - old_fibers
998+
if new_fibers.any?(&:alive?)
999+
message = "Alive fibers:\n\n".dup
1000+
new_fibers.select(&:alive?).each do |f|
1001+
message << " - #{f.inspect}\n"
1002+
f.backtrace.each do |line|
1003+
message << " #{line}\n"
1004+
end
1005+
end
1006+
puts message
10001007
end
1001-
assert_equal [false], all_fibers.map(&:alive?).uniq
1008+
assert_equal [false], new_fibers.map(&:alive?).uniq
10021009
ensure
10031010
GC.enable
10041011
end

spec/integration/rails/generators/graphql/input_generator_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class GraphQLGeneratorsInputGeneratorTest < BaseGeneratorTest
66
tests Graphql::Generators::InputGenerator
77

88
ActiveRecord::Schema.define do
9-
create_table :input_test_users do |t|
9+
create_table :input_test_users, force: true do |t|
1010
t.datetime :created_at
1111
t.date :birthday
1212
t.integer :points

spec/integration/rails/generators/graphql/object_generator_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class GraphQLGeneratorsObjectGeneratorTest < BaseGeneratorTest
66
tests Graphql::Generators::ObjectGenerator
77

88
ActiveRecord::Schema.define do
9-
create_table :test_users do |t|
9+
create_table :test_users, force: true do |t|
1010
t.datetime :created_at
1111
t.date :birthday
1212
t.integer :points, null: false

0 commit comments

Comments
 (0)