Skip to content

Commit f4cb972

Browse files
committed
Remove needless configsg
1 parent 8574545 commit f4cb972

File tree

5 files changed

+4
-7
lines changed

5 files changed

+4
-7
lines changed

lib/graphql/schema/build_from_definition.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ def build_enum_type(enum_type_definition, type_resolver)
298298
description: enum_value_definition.description,
299299
directives: builder.prepare_directives(enum_value_definition, type_resolver),
300300
ast_node: enum_value_definition,
301-
value_method: GraphQL::Schema::Enum.respond_to?(enum_value_definition.name.downcase) ? false : nil,
302301
)
303302
end
304303
end

lib/graphql/schema/loader.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ def define_type(type, type_resolver)
108108
enum_value["name"],
109109
description: enum_value["description"],
110110
deprecation_reason: enum_value["deprecationReason"],
111-
value_method: respond_to?(enum_value["name"].downcase) ? false : nil
112111
)
113112
end
114113
end

spec/graphql/schema/dynamic_members_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ class Thing < LegacyThing
175175

176176
class Language < BaseEnum
177177
value "RUBY"
178-
value "PERL6", deprecation_reason: "Use RAKU instead", future_schema: true, value_method: false
178+
value "PERL6", deprecation_reason: "Use RAKU instead", future_schema: true
179179
value "PERL6", future_schema: false
180180
value "RAKU", future_schema: true
181181
value "COFFEE_SCRIPT", future_schema: false
@@ -1026,7 +1026,7 @@ class BaseEnumValue < GraphQL::Schema::EnumValue
10261026
class DuplicateEnumValue < GraphQL::Schema::Enum
10271027
enum_value_class(BaseEnumValue)
10281028
value "ONE", description: "second definition", allow_for: [2, 3]
1029-
value "ONE", description: "first definition", allow_for: [1, 2], value_method: false
1029+
value "ONE", description: "first definition", allow_for: [1, 2]
10301030
end
10311031

10321032
class DuplicateFieldObject < GraphQL::Schema::Object

spec/graphql/schema/enum_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def value
160160
class MultipleNameTestEnum < GraphQL::Schema::Enum
161161
value "A"
162162
value "B", value: :a
163-
value "B", value: :b, value_method: false
163+
value "B", value: :b
164164
end
165165

166166
it "doesn't allow it from enum_values" do

spec/graphql/schema/loader_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919

2020
value "FOO", value: :foo
2121
value "BAR", deprecation_reason: "Don't use BAR"
22-
value "NAME", value_method: false
23-
value "foo", value_method: false
22+
value "foo"
2423
end
2524

2625
sub_input_type = Class.new(GraphQL::Schema::InputObject) do

0 commit comments

Comments
 (0)