Skip to content

Unify execution metadata #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmosolgo opened this issue Aug 10, 2017 · 2 comments
Closed

Unify execution metadata #882

rmosolgo opened this issue Aug 10, 2017 · 2 comments

Comments

@rmosolgo
Copy link
Owner

There are a lot of non-user-facing objects created to resolve a GraphQL query:

  • Tokens
  • AST nodes
  • Irep nodes
  • FieldResolutionContexts
  • FieldResults
  • SelectionResults
  • (and plenty more: Lazies, LazyConnectionWrapper, Irep Scopes ... 😬 )

I think some of these could be merged into one: FieldResolutionContext, FieldResult, SelectionResult. They all form a tree which corresponds to the final result. Merging them would open some interesting doors:

Also, it would be a performance improvement due to fewer allocations (#861)

I don't have a priority for this; I want to get a few features finished out first. But I thought I'd open the issue so people know that the idea is out there!

@rmosolgo
Copy link
Owner Author

Starting in #923

@rmosolgo
Copy link
Owner Author

rmosolgo commented Sep 8, 2017

This is finsihed on the 1.7.x branch

@rmosolgo rmosolgo closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant