Skip to content

Add error handling for the interpreter #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Add error handling for the interpreter #2458

merged 2 commits into from
Sep 2, 2019

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Sep 2, 2019

Based on https://github.com/exAspArk/graphql-errors and @thiago-sydow's comment over at #2139 (comment)

closes #2139

@rmosolgo rmosolgo added this to the 1.9.12 milestone Sep 2, 2019
@rmosolgo rmosolgo merged commit 8694844 into master Sep 2, 2019
@rmosolgo
Copy link
Owner Author

rmosolgo commented Sep 2, 2019

If you want to give this a try before the next release, you can bundle the gem's master branch:

gem "graphql", github: "rmosolgo/graphql-ruby"

And add the new plugin as described in the new docs

@thiago-sydow
Copy link

Nice to see that the initial implementation resulted in this. Thanks !

@exAspArk
Copy link
Contributor

exAspArk commented Apr 7, 2020

Awesome job! I'm going to deprecate graphql-errors now.
Thank you, one less project to support and worry about 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL::Execution::Interpreter and rescue_from compatibility
3 participants