Execution "path" from fragment fields is wrong #371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heh, I keep finding more problems with the implementation of error
"path"
. Basically my fault, I wrote this thing.The latest is that resolving fields within a fragment context have an incomplete path. They only walk up to the root of the fragment definition rather than the full query stack.
I'm thinking that using
irep_node
is probably the wrong path for recording this path stack. And I'm feeling a little stuck about where to track this stack best.To: @rmosolgo
CC: @mcolyer