Skip to content

Conversation

josh
Copy link
Contributor

@josh josh commented Nov 2, 2016

Heh, I keep finding more problems with the implementation of error "path". Basically my fault, I wrote this thing.

The latest is that resolving fields within a fragment context have an incomplete path. They only walk up to the root of the fragment definition rather than the full query stack.

I'm thinking that using irep_node is probably the wrong path for recording this path stack. And I'm feeling a little stuck about where to track this stack best.


To: @rmosolgo
CC: @mcolyer

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 2, 2016

Deferred execution has path built-in. I want to support it properly by changing execution in a big way, and I think it will support batching. But I need some time ...

@josh
Copy link
Contributor Author

josh commented Nov 3, 2016

Deferred execution has path built-in.

Oh, what file is that class in? Is it different than the serialize execution implementation?

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 3, 2016

#168 💓

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 5, 2016

I spent some time on that branch last night, it might be hard to ever get it in shape. I'm trying to introduce Execution::Frame in #378 which will also be the immutable, field-level context requested in #368

@rmosolgo rmosolgo mentioned this pull request Nov 6, 2016
2 tasks
@rmosolgo rmosolgo closed this in #379 Nov 7, 2016
@josh josh deleted the fragment-error-path branch November 7, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants