Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Argument Coercion Performance
This PR attempts to optimize the argument coercion process in GraphQL-Ruby by adding fast paths for common scenarios. I thought I'd create it as a draft so folks could give input and the CI would run.
Looks like I was a bit too eager, looking into the tests etc
Changes
schema/list.rb
)execution/interpreter/arguments_cache.rb
)schema/member/has_arguments.rb
)schema/argument.rb
)coerce_into_values
with a fast path for statically coercible argumentsBenchmarks
Performance improvements measured with isolated benchmarks, these were custom made as I couldn't get the benchmarks of the repository to run well 😅 :
List Coercion:
Argument Coercion: