Unify execution metadata objects #923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each key in the response, we create one
Contextand one-or-zeroFieldResult/SelectionResult. The leads to a lot of extra GC work, see this benchmark which highlightsgraphqloverhead:#861 (comment)
We can remove this overhead by using
Context#value/Context#value=to manage results.Another advantage is that you can backtrack through the results using
context.parent.value, which will fix #881.Also fixes #882.
Finally, this lays the groundwork for streaming execution. Since
ctxobjects track their underlying objects, they can be used to resume execution at any time. This could reduce TTFB with graphql-client.TODO:
query/context.rb:Query::Context&Query::Context::FieldResolutionContextMove to a new class which describes its current roleMay as well leave it, break less stuffContext.flattento somewhere that makes sense (insideExecution?)