Skip to content

Add support for external blob values in robotinterface #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PeterBowman
Copy link
Member

It is possible to externally (i.e. outside the XML robot configuration) override any parameters marked as extern-name with compound (lists) or simple (strings, integers...) values. This patch adds support for blobs, with unit testing (also covering external lists for completeness).

Use case: roboticslab-uc3m/yarp-devices#271 (comment).

@PeterBowman
Copy link
Member Author

Windows builds are failing, I'm going to submit a fix soon.

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

44.7% Coverage on New Code (required ≥ 80%)
26.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@PeterBowman
Copy link
Member Author

Windows builds are failing, I'm going to submit a fix soon.

Fixed, there's nothing a double pointer can't do 😏.

@PeterBowman
Copy link
Member Author

Should I rebase this and change the base branch to master according to the assigned milestone (YARP 3.10.0)?

@PeterBowman
Copy link
Member Author

Hello. Is there any action I should perform here to clarify the intention of the PR or perhaps enhance the unit tests? Would it be possible to consider it for the 3.11.x release train (instead of 3.12 or later)?

@traversaro
Copy link
Member

Hello. Is there any action I should perform here to clarify the intention of the PR or perhaps enhance the unit tests? Would it be possible to consider it for the 3.11.x release train (instead of 3.12 or later)?

fyi @randaz81

@randaz81
Copy link
Member

randaz81 commented May 23, 2025

We freezed this PR because it seems overcomplicated and difficult to maintain in the future.
Generally speaking, blob data type is something that we try to avoid (or remove!) as much as possible. If binary strings are required, I'd suggest avoiding passing through yarprobotinterface: you might want to provide a filename where the device can read it from in binary format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants