Fix support for consuming YCM via FetchContent_MakeAvailable and bump version to 0.17.1 #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support added in #463 for consuming
YCMviaFetchContent_MakeAvailablehad a bug, asFetchContent_MakeAvailableusesadd_subdirectoryunder the hood to include a project, andadd_subdirectorycreates a new variable scope, so all variables set in it where not propagated to the context whereFetchContent_MakeAvailable.This PR fixes the issue by setting the used variable in the
PARENT_SCOPE.