Skip to content

Adding Rocq Opam Version Support #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Adding Rocq Opam Version Support #135

merged 1 commit into from
May 14, 2025

Conversation

Durbatuluk1701
Copy link
Contributor

In reference to issue #134 .

I was hoping for some guidance on if further changes would be needed for the tested_coq_nix_versions and extracted_tested_coq_opam_versions?

Additionally, in the travis yml line 94 I left packages as coq-, does this seem reasonable or should it be rocq-?

liyishuai
liyishuai approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@liyishuai liyishuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested on my side. Do you have links to running examples?

@liyishuai
Copy link
Member

liyishuai commented Mar 17, 2025 •
edited
Loading

Additionally, in the travis yml line 94 I left packages as coq-, does this seem reasonable or should it be rocq-?

I'd suggest coq- as-is, unless we have a convention that all 8&9-compatible packages are double-released as coq-foo and rocq-foo on OPAM.

@liyishuai liyishuai linked an issue Mar 17, 2025 that may be closed by this pull request
Update the templates w.r.t. the coq→rocq renaming ? #134
Closed
@Durbatuluk1701
Copy link
Contributor Author

Haven't tested on my side. Do you have links to running examples?

Don't have an example yet, will get back to you once I do

@liyishuai liyishuai self-requested a review March 26, 2025 06:18
Zimmi48
Zimmi48 approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have only tested the GitHub workflow generation, but that's the most important anyway (not sure if anyone uses Travis or Circle CI anymore).

@Zimmi48 Zimmi48 merged commit b9d5901 into rocq-community:master May 14, 2025
1 check passed
@Durbatuluk1701 Durbatuluk1701 deleted the rocq_compat branch July 10, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@liyishuai liyishuai liyishuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the templates w.r.t. the coq→rocq renaming ?
3 participants
@Durbatuluk1701 @liyishuai @Zimmi48