Skip to content

Commit bbc0645

Browse files
Merge PR #21095: Ltac2 builtin printers: fix some too-tight precedence levels
Reviewed-by: proux01 Co-authored-by: proux01 <proux01@users.noreply.github.com>
2 parents 8e044a5 + 035a5dd commit bbc0645

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

plugins/ltac2/tac2extravals.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ let () =
7575
let intern = intern_constr_tacexpr in
7676
let interp ist c = interp_constr Tac2core.constr_flags ist c in
7777
let print env sigma c = str "constr:(" ++ Printer.pr_lglob_constr_env env sigma c ++ str ")" in
78-
let raw_print env sigma c = str "constr:(" ++ Ppconstr.pr_constr_expr env sigma c ++ str ")" in
78+
let raw_print env sigma c = str "constr:(" ++ Ppconstr.pr_lconstr_expr env sigma c ++ str ")" in
7979
let subst subst c = Detyping.subst_glob_constr (Global.env()) subst c in
8080
let obj = {
8181
ml_intern = intern;
@@ -90,7 +90,7 @@ let () =
9090
let intern = intern_constr_tacexpr in
9191
let interp ist c = interp_constr Tac2core.open_constr_no_classes_flags ist c in
9292
let print env sigma c = str "open_constr:(" ++ Printer.pr_lglob_constr_env env sigma c ++ str ")" in
93-
let raw_print env sigma c = str "open_constr:(" ++ Ppconstr.pr_constr_expr env sigma c ++ str ")" in
93+
let raw_print env sigma c = str "open_constr:(" ++ Ppconstr.pr_lconstr_expr env sigma c ++ str ")" in
9494
let subst subst c = Detyping.subst_glob_constr (Global.env()) subst c in
9595
let obj = {
9696
ml_intern = intern;
@@ -131,7 +131,7 @@ let () =
131131
Patternops.subst_uninstantiated_pattern env sigma subst c
132132
in
133133
let print env sigma pat = str "pat:(" ++ Printer.pr_uninstantiated_lconstr_pattern_env env sigma pat ++ str ")" in
134-
let raw_print env sigma pat = str "pat:(" ++ Ppconstr.pr_constr_pattern_expr env sigma pat ++ str ")" in
134+
let raw_print env sigma pat = str "pat:(" ++ Ppconstr.pr_lconstr_pattern_expr env sigma pat ++ str ")" in
135135
let interp env c =
136136
let ist = to_lvar env in
137137
Tac2core.pf_apply ~catch_exceptions:true begin fun env sigma ->
@@ -175,7 +175,7 @@ let () =
175175
in
176176
hov 2 (str "preterm:(" ++ ppids ++ Printer.pr_lglob_constr_env env sigma c ++ str ")")
177177
in
178-
let raw_print env sigma c = str "preterm:(" ++ Ppconstr.pr_constr_expr env sigma c ++ str ")" in
178+
let raw_print env sigma c = str "preterm:(" ++ Ppconstr.pr_lconstr_expr env sigma c ++ str ")" in
179179
let obj = {
180180
ml_intern = intern;
181181
ml_interp = interp;

plugins/ltac2/tac2print.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -963,7 +963,7 @@ end
963963
let () = register_init "preterm" begin fun env sigma c ->
964964
let c = to_preterm c in
965965
(* XXX should we get the ltac2 env out of the closure and print it too? Maybe with a debug flag? *)
966-
let c = try Printer.pr_closed_glob_env env sigma c with _ -> str "..." in
966+
let c = try Printer.pr_closed_lglob_env env sigma c with _ -> str "..." in
967967
hov 2 (str "preterm:(" ++ c ++ str ")")
968968
end
969969

printing/printer.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ let pr_closed_glob_n_env ?goal_concl_style ?inctx ?scope env sigma n c =
110110
pr_constr_expr_n env sigma n (extern_closed_glob ?goal_concl_style ?inctx ?scope env sigma c)
111111
let pr_closed_glob_env ?goal_concl_style ?inctx ?scope env sigma c =
112112
pr_constr_expr env sigma (extern_closed_glob ?goal_concl_style ?inctx ?scope env sigma c)
113+
let pr_closed_lglob_env ?goal_concl_style ?inctx ?scope env sigma c =
114+
pr_lconstr_expr env sigma (extern_closed_glob ?goal_concl_style ?inctx ?scope env sigma c)
113115

114116
let pr_lconstr_pattern_env env sigma c =
115117
pr_lconstr_pattern_expr env sigma (extern_constr_pattern (Termops.names_of_rel_context env) sigma c)

printing/printer.mli

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ val pr_type_env : ?goal_concl_style:bool -> env -> evar_map -> types
103103

104104
val pr_closed_glob_n_env : ?goal_concl_style:bool -> ?inctx:bool -> ?scope:scope_name -> env -> evar_map -> Constrexpr.entry_relative_level -> closed_glob_constr -> Pp.t
105105
val pr_closed_glob_env : ?goal_concl_style:bool -> ?inctx:bool -> ?scope:scope_name -> env -> evar_map -> closed_glob_constr -> Pp.t
106+
val pr_closed_lglob_env : ?goal_concl_style:bool -> ?inctx:bool -> ?scope:scope_name -> env -> evar_map -> closed_glob_constr -> Pp.t
106107

107108
val pr_ljudge_env : env -> evar_map -> EConstr.unsafe_judgment -> Pp.t * Pp.t
108109

0 commit comments

Comments
 (0)