Experiment to improve parsing errors #20970
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
github-actions
bot
added
the
needs: rebase
|
The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed. |
SkySkimmer
force-pushed
the
grammar-errors
branch
from
6b1d2ac to
cfa6f32
Compare
coqbot-app
bot
added
needs: full CI
github-actions
bot
added
the
needs: rebase
eg on `Open Scope Type` we used to get `Syntax error: illegal begin of toplevel:vernac_toplevel` now it also says `after Open Scope, expected identifier`. The current state is not entirely satisfying, eg on `Doesntexist.` it gives the list of command initial keywords, with "end of input" in the middle, yet is not a complete list of possible beginnings such as attributes (as can be seen in the test suite).
SkySkimmer
force-pushed
the
grammar-errors
branch
from
cfa6f32 to
a7f4e94
Compare
coqbot-app
bot
removed
the
needs: rebase
github-actions
bot
added
the
needs: rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg on
Open Scope Typewe used to getSyntax error: illegal begin of toplevel:vernac_toplevelnow it also says
after Open Scope, expected identifier.The current state is not entirely satisfying, eg on
Doesntexist.itgives the list of command initial keywords, with "end of input" in themiddle,
yet is not a complete list of possible beginnings such as
attributes (as can be seen in the test suite).
Fix #14098
Depends: