Make sure coqdep does not misinterpret "Importfoo" (fix #20984). #21000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silene
added
kind: fix
coqbot-app
bot
removed
the
request: full CI
|
This change seems incorrect on eg |
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
reviewed
Aug 12, 2025
| { require_file from lexbuf } | ||
| | "Export" space* | ||
| { require_file from lexbuf } | ||
| | ("Import" | "Export") space* ("-" space*)? ((space | "(") as p) |
There was a problem hiding this comment.
all those space* should be able to tolerate comments too (comments between - and ( were already bugged before this PR, but I think something like Require Import (* hints cause TC loop *) -(hints) foo would work before this PR)
SkySkimmer
added
needs: fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / closes #20984