Skip to content

Conversation

ppedrot
Copy link
Member

@ppedrot ppedrot commented Sep 29, 2025

It is only used in a single place in our codebase, for what seems not to be a great reason, and relies on canonical equality.

It is only used in a single place in our codebase, for what seems not to be
a great reason, and relies on canonical equality.
@ppedrot ppedrot added this to the 9.2+rc1 milestone Sep 29, 2025
@ppedrot ppedrot requested a review from a team as a code owner September 29, 2025 06:52
@ppedrot ppedrot added the kind: cleanup Code removal, deprecation, refactorings, etc. label Sep 29, 2025
@ppedrot ppedrot requested a review from a team as a code owner September 29, 2025 06:52
@ppedrot ppedrot added the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 29, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 29, 2025
@SkySkimmer SkySkimmer added the needs: overlay This is breaking external developments we track in CI. label Sep 29, 2025
@SkySkimmer
Copy link
Contributor

Used in mtac2
They should probably be using the econstr version though (which takes an env)

@SkySkimmer SkySkimmer self-assigned this Sep 29, 2025
ppedrot added a commit to ppedrot/Mtac2 that referenced this pull request Sep 29, 2025
Janno pushed a commit to Mtac2/Mtac2 that referenced this pull request Sep 30, 2025
@ppedrot ppedrot removed the needs: overlay This is breaking external developments we track in CI. label Sep 30, 2025
@ppedrot
Copy link
Member Author

ppedrot commented Sep 30, 2025

Mtac2 overlay merged, this is ready to go.

@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 9c0082c into rocq-prover:master Sep 30, 2025
8 checks passed
@ppedrot ppedrot deleted the rm-constr-is-refx branch September 30, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup Code removal, deprecation, refactorings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants