Rely less on the global environment when computing abstract names. #21138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
reviewed
Sep 29, 2025
| including those defined by [tclABSTRACT]. *) | ||
| let kn = Lib.make_kn id in | ||
| let kn = Names.Constant.make1 kn in | ||
| Environ.mem_constant kn env |
There was a problem hiding this comment.
this doesn't avoid inductive and constructor names though
There was a problem hiding this comment.
Let's try with a second variant expecting only constants to be locally defined in the environment and still checking the global safe env for other labels.
|
@coqbot ci minimize |
This code is buggy, but I do not see a way to do this correctly without first changing the APIs. This patch makes it clear we need to access the section context of the global environment while still only caring for the locally defined constants of the monad-provided one.
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
abstract-generate-name-with-local-globenv
branch
from
41fd475 to
729d184
Compare
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Sep 30, 2025
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is buggy, but I do not see a way to do this correctly without first changing the APIs. This patch makes it clear we need to access the section context of the global environment while still only caring for the locally defined constants of the monad-provided one.