830-refactor: Move style params to scss variables #891
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ | |
|
|
||
| padding-left: 12px; | ||
|
|
||
| font-size: $font-size-xs; | ||
| text-align: left; | ||
| list-style-type: none; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,5 +43,5 @@ | |
| } | ||
|
|
||
| .subresult p { | ||
| font-size: $font-size-xs; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -131,7 +131,7 @@ figure { | |
|
|
||
| height: var(--slider-arrow-btn-height); | ||
| margin: 2px; | ||
| border-radius: $border-radius-xs; | ||
|
|
||
| opacity: $opacity-100; | ||
| backdrop-filter: blur(20px); | ||
|
|
@@ -205,7 +205,7 @@ figure { | |
| width: 100%; | ||
| height: 100%; | ||
|
|
||
| font-size: $font-size-xl; | ||
| color: $color-white; | ||
|
|
||
| background: $color-gray-400; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
|
|
||
| min-width: 100px; | ||
| height: 100%; | ||
| border-radius: $border-radius-s; | ||
|
|
||
| &::before { | ||
| content: ''; | ||
|
|
@@ -33,13 +33,13 @@ | |
|
|
||
| overflow: hidden; | ||
| display: flex; | ||
| gap: $gap-s; | ||
| align-items: center; | ||
|
|
||
| height: 100%; | ||
| min-height: 112px; | ||
| padding: 36px 32px; | ||
| border-radius: $border-radius-s $border-radius-s 0 0; | ||
|
|
||
| background-color: $color-purple-50; | ||
|
|
||
|
|
@@ -57,15 +57,15 @@ | |
|
|
||
| .course-info { | ||
| display: flex; | ||
| gap: $gap-s; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
|
|
||
| padding: 32px; | ||
| border-color: $color-gray-200; | ||
| border-style: solid; | ||
| border-width: 0 1px 1px 1px; | ||
| border-radius: 0 0 $border-radius-s $border-radius-s; | ||
|
|
||
| background-color: $color-white; | ||
|
|
||
|
|
@@ -103,7 +103,7 @@ | |
|
|
||
| .course-info { | ||
| padding: 24px; | ||
| font-size: $font-size-xs; | ||
|
|
||
| @include media-laptop-medium { | ||
| flex-direction: row; | ||
|
|
@@ -117,7 +117,7 @@ | |
| .course-link { | ||
| gap: 4px; | ||
| padding: 10px 12px; | ||
| font-size: $font-size-xs; | ||
| } | ||
|
|
||
| section { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ | |
| .course-info { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $gap-xs; | ||
|
|
||
| width: 100%; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
|
|
||
| width: 320px; | ||
| padding: 0; | ||
| border-radius: $border-radius-s; | ||
|
|
||
| .card-header { | ||
| position: relative; | ||
|
|
@@ -16,7 +16,7 @@ | |
| padding: 32px 24px 24px 24px; | ||
| border: solid $color-gray-200; | ||
| border-width: 1px 1px 0 1px; | ||
| border-radius: $border-radius-s $border-radius-s 0 0; | ||
|
|
||
| background-color: $color-purple-50; | ||
|
|
||
|
|
@@ -38,7 +38,7 @@ | |
| border: 4px solid $color-purple-100; | ||
| border-radius: 36px; | ||
|
|
||
| font-size: $font-size-s; | ||
| line-height: 1.2; | ||
| } | ||
|
|
||
|
|
@@ -73,7 +73,7 @@ | |
| margin-top: 0; | ||
| margin-bottom: 8px; | ||
|
|
||
| font-size: $font-size-s; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| } | ||
|
|
@@ -92,7 +92,7 @@ | |
| padding: 24px; | ||
| border: solid $color-gray-200; | ||
| border-width: 0 1px 1px 1px; | ||
| border-radius: 0 0 $border-radius-s $border-radius-s; | ||
|
|
||
| background-color: hsla(from $color-gray-100 h s l/ $opacity-20); | ||
|
|
||
|
|
@@ -104,7 +104,7 @@ | |
|
|
||
| margin-bottom: 16px; | ||
|
|
||
| font-size: $font-size-xs; | ||
| font-weight: $font-weight-medium; | ||
| color: $color-gray-500; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| .card { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $gap-l; | ||
| } | ||
|
|
||
| .card-wrapper { | ||
| max-width: 624px; | ||
| min-height: 510px; | ||
| padding: 40px 32px 40px 32px; | ||
| border-radius: $border-radius-s; | ||
|
|
||
| box-shadow: 0 4px 12px 0 hsla(from $color-black h s l / $opacity-10); | ||
|
|
||
|
|
@@ -36,7 +36,7 @@ | |
|
|
||
| .card-info { | ||
| display: flex; | ||
| gap: $gap-l; | ||
| align-items: center; | ||
| } | ||
|
|
||
|
|
@@ -54,7 +54,7 @@ | |
| .card-content-wrapper { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $gap-l; | ||
| align-items: flex-start; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| .trainer-card { | ||
| display: flex; | ||
| gap: $gap-l; | ||
| align-items: flex-start; | ||
| justify-content: space-between; | ||
|
|
||
| max-width: 700px; | ||
| padding: 40px 32px 40px 32px; | ||
| border-radius: $border-radius-m; | ||
|
|
||
| box-shadow: 0 4px 16px 0 rgb(0 0 0 / 12%); | ||
|
|
||
|
|
@@ -17,7 +17,7 @@ | |
| img { | ||
| width: 100%; | ||
| height: auto; | ||
| border-radius: $border-radius-s; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -31,13 +31,13 @@ | |
|
|
||
| .card-subtitle { | ||
| margin: 0; | ||
| font-size: $font-size-m; | ||
| line-height: 1.15; | ||
| color: $color-gray-500; | ||
| } | ||
|
|
||
| .card-content { | ||
| font-size: $font-size-s; | ||
| font-weight: $font-weight-regular; | ||
| line-height: 24px; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| .date { | ||
| display: flex; | ||
| gap: $gap-xs; | ||
| align-items: center; | ||
| justify-content: flex-start; | ||
|
|
||
| margin: 0; | ||
|
|
||
| font-size: $font-size-xs; | ||
| } | ||
|
|
||
| .icon { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
|
|
||
| display: flex; | ||
| flex-flow: row nowrap; | ||
| gap: $gap-xs; | ||
| place-content: center center; | ||
| align-items: center; | ||
|
|
||
|
|
@@ -19,7 +19,7 @@ | |
| padding: 12px 24px; | ||
| border: 1px solid $color-black; | ||
|
|
||
| font-size: $font-size-m; | ||
| color: $color-black; | ||
|
|
||
| .icon-wrapper { | ||
|
|
@@ -41,7 +41,7 @@ | |
| padding: 16px 24px; | ||
| border: 2px solid $color-black; | ||
|
|
||
| font-size: $font-size-m; | ||
| line-height: 24px; | ||
| color: $color-white; | ||
|
|
||
|
|
@@ -61,9 +61,9 @@ | |
| width: max-content; | ||
| height: 36px; | ||
| padding: 10px 12px; | ||
| border-radius: $border-radius-xxxl; | ||
|
|
||
| font-size: $font-size-xs; | ||
| line-height: 16px; | ||
| color: $color-black; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| .list { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $gap-xs; | ||
|
|
||
| font-size: $font-size-m; | ||
| line-height: 28px; | ||
| letter-spacing: 0.5px; | ||
| list-style-type: none; | ||
|
|
@@ -13,7 +13,7 @@ | |
| letter-spacing: 0; | ||
|
|
||
| @include media-laptop { | ||
| font-size: $font-size-s; | ||
| line-height: 24px; | ||
| } | ||
| } | ||
|
|
@@ -23,6 +23,6 @@ | |
| } | ||
|
|
||
| @include media-tablet-large { | ||
| font-size: $font-size-s; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| @include media-tablet { | ||
| padding-bottom: 16px; | ||
| font-size: $font-size-xxl; | ||
| line-height: 44px; | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add
$border-radius-xxs: 4px;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it. But I'm not sure about the names of z-indexes though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our project we have
-1,1,2,10/100. Maybe:-1-bottom,1-default,2-top,10/100-max@SpaNb4 @Quiddlee what do you think, guys?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ansivgit, I think we could use something similar to:
https://www.smashingmagazine.com/2021/02/css-z-index-large-projects/
As alternatives to
bottomandtopAlso, shouldn't the default be 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! And I just suggest to add
max = 999