🩹 fix: Clean output buffering up to initial level #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #406
The
registerWordPressRoute
method deletes all levels of output buffering. Caching plugins try to buffer the whole output and write that to a file. Output buffering is started by caching plugins in{wp-content|app}/advanced-cache.php
, and saved in a callback for thatob_start()
. As acorn is deleting all buffers from all levels inBootable::registerWordPressRoute()
, the output is empty by the time the caching plugin's callback is called.With this PR, we get the initial ob level, and delete buffers up until this level.
I have tested this fix with
and didn't encounter any issues, but please test thoroughly, as this is quite a critical change.