Skip to content

About pre-commit hook #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfiamene opened this issue Mar 8, 2021 · 0 comments
Open

About pre-commit hook #46

sfiamene opened this issue Mar 8, 2021 · 0 comments

Comments

@sfiamene
Copy link

sfiamene commented Mar 8, 2021

Could someone please share your thoughts about why this was implemented this way?

We faced that when we add a new commit to a branch we end up with all the code modified and sometimes the changes that we added are deleted. This can be prevented by adding the flag --no-verify when commiting but it makes no sense to have a tool configured and then avoid using it on purpose.

Other findings were that the steps ktlintFormat and ktkint when excecuted separately doesn't make any modifications to the code, so the issue could be made by the stash commands.

I'd like to open a discuss here about how to improve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant