Skip to content

[Units] Discussion about current unit list #343

@earnaud

Description

@earnaud

Hi ropensci team,

I am working again on some units issue on my own work, and I have some questions/ideas.
EDIT: I deleted the two previous issues #330 and #314 that I had previously opened to merge them into a discussion here.

Current unit list structure

get_unitList()$units returns a very useful data.frame of all available units. However, some seems to be duplicated and others do not have unitType where they shall have one (spectral radiance for example). I have already worked on those to fill the gaps in the "unitType" column. You can find the file attached (yes, .ods but I wanted to keep the formatting ok). The bold text is the one I reworked. Let me know if this is a convenient document for you. I have a doubt about "PhotosyntheticPhotonFlux" as unitType, since it is more the name of a measure and not a proper type.

EML_units.ods

Missing units

Some colleagues did not find some units in your unit list. However, these units (like Julian_year) are listed in the UniData documentation (https://www.unidata.ucar.edu/software/udunits/udunits-2.2.28/udunits2-common.xml). Since you refer to unidata in the unitList, I wondered what choices prevented you from using these units too. Also, I am willing to review the unit List and add the missing units I noticed.
In the same way, I have users working in paleontology, and some of their time periods are expressed in thousand of years (or even millions): would you think this would be okay to add such units as "kiloyears" (or equivalent) without interfering with the EML standard unit list? (I believe not but there might be a way I did not think about).
EDIT: I also saw that parts per million/billion/trillion/volume were missing. All are not crucial but ppm and ppb are regularly used.

Thanks again for your work, and let me know if I can help on this part of the tool, I am more than willing to help !

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions