Skip to content

Replace std_msgs with example_interfaces #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 30, 2024

std_msgs was deprecated since Foxy ros2/examples#356 this PR replaces std_msgs with example_interfaces

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 30, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't realized yet that they are deprecated 😱 Don't we have to change that on ros2_controllers side first? I can do that in the next days..

@christophfroehlich
Copy link
Contributor

And to follow the intention of the deprecation, we should add "meaningful" messages to control_msgs first.

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
@christophfroehlich
Copy link
Contributor

This should definitely be fixed in control_msgs and ros2_controllers, see ros-controls/ros2_controllers#157
Then we should apply the changes to the remaining occurrences in this repo here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants