Skip to content

Cleanup code and use composable nodes for Gazebo #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: rolling
Choose a base branch
from

Conversation

Amronos
Copy link
Contributor

@Amronos Amronos commented Mar 10, 2025

I have currently made these changes only for the diff_drive_controller demo and will propagate them to the other demos if they look good.

Demos completed:

  • cart_example_position
  • cart_example_velocity
  • cart_example_effort
  • diff_drive
  • tricycle_drive
  • ackermann_drive
  • mecanum_drive
  • gripper_mimic_joint_example_position
  • gripper_mimic_joint_example_effort
  • pendulum_example_effort
  • pendulum_example_position

@Amronos Amronos requested a review from ahcorde as a code owner March 10, 2025 03:26
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the composable nodes of gazebo. How does #375 (comment) apply then? If we advertise this here, should we fix what is mentioned there before?

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@Amronos
Copy link
Contributor Author

Amronos commented Mar 15, 2025

I'm not familiar with the composable nodes of gazebo. How does #375 (comment) apply then? If we advertise this here, should we fix what is mentioned there before?

TBH, I am not really sure about that. From my testing passing parameters through URDF/SDF works just fine when using composable nodes (there was #441 which was fixed with #442).
I think #166 and #196 are more related to using multiple gz_ros2_control plugins and passing command line arguments.
@azeey can you provide some help here?

@Amronos Amronos marked this pull request as draft March 26, 2025 08:11
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example_mobile_robots part is fine, can you please split this up in separate PRs?

About os.path.join see the conversation there.

@Amronos
Copy link
Contributor Author

Amronos commented Mar 26, 2025

The example_mobile_robots part is fine, can you please split this up in separate PRs?

Will do.

@Amronos
Copy link
Contributor Author

Amronos commented Mar 27, 2025

Shifted the cmd_vel unification to #530.

@Amronos
Copy link
Contributor Author

Amronos commented Mar 27, 2025

Shifted the addition of odometry plugin to #531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants