-
Notifications
You must be signed in to change notification settings - Fork 109
Cleanup code and use composable nodes for Gazebo #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the composable nodes of gazebo. How does #375 (comment) apply then? If we advertise this here, should we fix what is mentioned there before?
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
TBH, I am not really sure about that. From my testing passing parameters through URDF/SDF works just fine when using composable nodes (there was #441 which was fixed with #442). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example_mobile_robots part is fine, can you please split this up in separate PRs?
About os.path.join see the conversation there.
Will do. |
Shifted the cmd_vel unification to #530. |
Shifted the addition of odometry plugin to #531. |
I have currently made these changes only for thediff_drive_controller
demo and will propagate them to the other demos if they look good.Demos completed: