Skip to content

Commit b1ca756

Browse files
committed
add different sleeps for better statistics testing
1 parent cae6bca commit b1ca756

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

hardware_interface_testing/test/test_components/test_actuator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class TestActuator : public ActuatorInterface
143143
if (get_hardware_info().is_async)
144144
{
145145
std::this_thread::sleep_for(
146-
std::chrono::milliseconds(1000 / (3 * get_hardware_info().rw_rate)));
146+
std::chrono::milliseconds(1000 / (6 * get_hardware_info().rw_rate)));
147147
}
148148
// simulate error on write
149149
if (velocity_command_ == test_constants::WRITE_FAIL_VALUE)

hardware_interface_testing/test/test_components/test_system.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class TestSystem : public SystemInterface
132132
if (get_hardware_info().is_async)
133133
{
134134
std::this_thread::sleep_for(
135-
std::chrono::milliseconds(1000 / (3 * get_hardware_info().rw_rate)));
135+
std::chrono::milliseconds(1000 / (6 * get_hardware_info().rw_rate)));
136136
}
137137
// simulate error on write
138138
if (velocity_command_[0] == test_constants::WRITE_FAIL_VALUE)

hardware_interface_testing/test/test_resource_manager.cpp

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1885,10 +1885,11 @@ class ResourceManagerTestReadWriteDifferentReadWriteRate : public ResourceManage
18851885
{
18861886
if (i > (cm_update_rate_ / rate))
18871887
{
1888-
const double expec_execution_time = (1.e6 / (3 * rate)) + 200.0;
1888+
const double expec_read_execution_time = (1.e6 / (3 * rate)) + 200.0;
1889+
const double expec_write_execution_time = (1.e6 / (6 * rate)) + 200.0;
18891890
EXPECT_LT(
18901891
status_map[component_name].read_statistics->execution_time.get_statistics().average,
1891-
expec_execution_time);
1892+
expec_read_execution_time);
18921893
EXPECT_LT(
18931894
status_map[component_name].read_statistics->periodicity.get_statistics().average,
18941895
1.2 * rate);
@@ -1901,7 +1902,7 @@ class ResourceManagerTestReadWriteDifferentReadWriteRate : public ResourceManage
19011902

19021903
EXPECT_LT(
19031904
status_map[component_name].write_statistics->execution_time.get_statistics().average,
1904-
expec_execution_time);
1905+
expec_write_execution_time);
19051906
EXPECT_LT(
19061907
status_map[component_name].write_statistics->periodicity.get_statistics().average,
19071908
1.2 * rate);
@@ -2290,29 +2291,30 @@ class ResourceManagerTestAsyncReadWrite : public ResourceManagerTest
22902291
if (check_for_updated_values)
22912292
{
22922293
const unsigned int rw_rate = 100u;
2293-
const double expec_execution_time = (1.e6 / (3 * rw_rate)) + 200.0;
2294+
const double expec_read_execution_time = (1.e6 / (3 * rw_rate)) + 200.0;
2295+
const double expec_write_execution_time = (1.e6 / (6 * rw_rate)) + 200.0;
22942296
check_periodicity(TEST_ACTUATOR_HARDWARE_NAME, rw_rate);
22952297
check_periodicity(TEST_SYSTEM_HARDWARE_NAME, rw_rate);
22962298
EXPECT_LT(
22972299
status_map[TEST_ACTUATOR_HARDWARE_NAME]
22982300
.read_statistics->execution_time.get_statistics()
22992301
.average,
2300-
expec_execution_time);
2302+
expec_read_execution_time);
23012303
EXPECT_LT(
23022304
status_map[TEST_ACTUATOR_HARDWARE_NAME]
23032305
.write_statistics->execution_time.get_statistics()
23042306
.average,
2305-
expec_execution_time);
2307+
expec_write_execution_time);
23062308
EXPECT_LT(
23072309
status_map[TEST_SYSTEM_HARDWARE_NAME]
23082310
.read_statistics->execution_time.get_statistics()
23092311
.average,
2310-
expec_execution_time);
2312+
expec_read_execution_time);
23112313
EXPECT_LT(
23122314
status_map[TEST_SYSTEM_HARDWARE_NAME]
23132315
.write_statistics->execution_time.get_statistics()
23142316
.average,
2315-
expec_execution_time);
2317+
expec_write_execution_time);
23162318
}
23172319
}
23182320

0 commit comments

Comments
 (0)