Skip to content

Cleanup old internal API (backport #2346) #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 1, 2025

This PR cleans up old internal API that is unused after #2323 :)


This is an automatic backport of pull request #2346 done by Mergify.

@mergify mergify bot added the conflicts label Jul 1, 2025
Copy link
Contributor Author

mergify bot commented Jul 1, 2025

Cherry-pick of cd7e522 has failed:

On branch mergify/bp/jazzy/pr-2346
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit cd7e522.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/controller_manager.cpp
	both modified:   hardware_interface/src/resource_manager.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@saikishor saikishor force-pushed the mergify/bp/jazzy/pr-2346 branch from 32ead51 to 4b275d6 Compare July 21, 2025 11:03
@saikishor saikishor force-pushed the mergify/bp/jazzy/pr-2346 branch from 3fe6c37 to 09e2b0b Compare July 21, 2025 11:26
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (9c9d361) to head (09e2b0b).
Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2358      +/-   ##
==========================================
+ Coverage   88.60%   88.63%   +0.02%     
==========================================
  Files         148      148              
  Lines       16918    16918              
  Branches     1446     1446              
==========================================
+ Hits        14991    14995       +4     
+ Misses       1371     1367       -4     
  Partials      556      556              
Flag Coverage Δ
unittests 88.63% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 74.71% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmagyar bmagyar merged commit 2d895c2 into jazzy Jul 21, 2025
10 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/jazzy/pr-2346 branch July 21, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants