Skip to content

Addition of a Default Node for Hardware Component (backport #2348) #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 23, 2025

Brief

Now that we have access to the CM's executor from #2323, the user can add their nodes to it and create publishers and subscribers from them. The next step, which this PR addresses, is adding a node by default, with the hardware components name, and giving the user access to it through a get_node method.


This is an automatic backport of pull request #2348 done by [Mergify](https://mergify.com).

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (099cec1) to head (de1d00b).
Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2413      +/-   ##
==========================================
- Coverage   88.62%   88.62%   -0.01%     
==========================================
  Files         148      148              
  Lines       16918    16961      +43     
  Branches     1446     1449       +3     
==========================================
+ Hits        14994    15032      +38     
- Misses       1367     1373       +6     
+ Partials      557      556       -1     
Flag Coverage Δ
unittests 88.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/hardware_interface/actuator_interface.hpp 91.62% <100.00%> (+0.31%) ⬆️
...ce/include/hardware_interface/sensor_interface.hpp 86.84% <100.00%> (+0.86%) ⬆️
...ce/include/hardware_interface/system_interface.hpp 85.30% <100.00%> (+0.50%) ⬆️
...e_interface_testing/test/test_resource_manager.cpp 99.46% <100.00%> (+0.01%) ⬆️
...e_interface_testing/test/test_resource_manager.hpp 95.00% <100.00%> (+0.55%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmagyar bmagyar merged commit 208f63f into jazzy Jul 23, 2025
12 of 15 checks passed
@bmagyar bmagyar deleted the mergify/bp/jazzy/pr-2348 branch July 23, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants