Remove spurious global declaration. #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ansi is not currently used as a global (it is a module variable in this file only and flake8 now catches and lints this unneeded declaration.
The flake8 global complaint () has previously caught cases where the global declaration was unecessary. In this case, a test started failing after the change and I'm struggling to understand how the previous behavior was working properly since as far as I can tell it does overwrite the global rather than update it.
cottsay
approved these changes
Jul 7, 2025
nuclearsandwich
commented
Jul 7, 2025
|
|
||
| def enable_ANSI_colors(): | ||
| """Populate the global module dictionary `ansi` with ANSI escape sequences.""" | ||
| global _ansi |
There was a problem hiding this comment.
This is in the commit history now but as it happens this usage was not spurious nor flagged by flake8 but I assumed that 2/3 == 3/3 and removed it anyway. In order to fix the failing test without restoring the use of the global declaration I changed the code to update rather than assign and I think it's cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ansi is not currently used as a global (it is a module variable in this file only and flake8 now catches and lints this unneeded declaration.