fix(dependency_walker): don't get dependencies of non ROS packages #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we consider non-ROS dep, we don't want to look for the ROS dependencies of non ROS packages (ie: cmake)
Guillaumebeuzeboc
force-pushed
the
fix/don_t_get_dependencies_of_non_ros_packages
branch
from
c742995 to
76a44b6
Compare
|
Hi @cottsay, could we get a workflow approval? Thanks. |
|
Sorry for the long delay. This looks like a good change. I'm not sure why the Action workflows aren't triggering. Can you try to rebase this to trigger it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
DependencyWalkerand callingget_recursive_dependswith theros_packages_onlytoFalse, theDependencyWalkertries to get the dependencies of every dependency (even the non-ROS ones).In order to get the dependencies of a package we must get the corresponding ROS package (for the XML etc). This is not possible for non ROS packages (like
CMake,boostetc). Hence this causes aKeyError.I simply added a check to verify if the package is a ROS package or not before trying to get its dependencies.