Skip to content

fix(dependency_walker): don't get dependencies of non ROS packages #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dependency_walker): don't get dependencies of non ROS packages #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/rosdistro/dependency_walker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ def _get_package_names(self):

def get_depends(self, pkg_name, depend_type, ros_packages_only=False):
'''Return a set of package names which the package depends on.'''
# We can only get the dependencies of ROS packages
if pkg_name not in self._get_package_names():
return set()
deps = self._get_dependencies(pkg_name, depend_type)
if ros_packages_only:
deps &= set(self._get_package_names())
Expand Down
Loading