-
Notifications
You must be signed in to change notification settings - Fork 8
Migrate subsection of vcstools' API for compatibility with bloom #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leander-dsouza
wants to merge
16
commits into
main
Choose a base branch
from
leander-dsouza/vcstools-port
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5730d2c
to
650fcd3
Compare
659c3b8
to
5f6ce04
Compare
477c4be
to
d08697b
Compare
5f6ce04
to
e47aac4
Compare
8e32c1a
to
138ad9f
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
138ad9f
to
83040dc
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 26.98% 28.94% +1.95%
==========================================
Files 31 31
Lines 2238 2477 +239
Branches 392 439 +47
==========================================
+ Hits 604 717 +113
- Misses 1574 1686 +112
- Partials 60 74 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@leander-dsouza, I noticed that some implementations of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Please refer #751 for verifying integration with bloom.
Basic Info
Description of contribution in a few bullet points
This ports over four main functions from vcstools, namely
export_repositories
,checkout
,get_vcs_client
, andget_path
for all the VCS clients.This is because these are the four prominent methods used in bloom as seen here.
checkout
referenceexport_repositories
referenceget_vcs_client
referenceget_path
referenceIn addition, the corresponding integration tests have been added to both of these functions across
svn
,bzr
,hg
, andgit
clients.Breezy has been added to the CI for testing on macOS and Ubuntu.
The integration can be safely verified in #751 at bloom. All the system and unit tests pass upon merge.
Description of how this change was tested
Ran
pytest
locally to ensure all the unit and linting tests pass:pytest -s -v test
Signed-off-by: Leander Stephen Desouza leanderdsouza1234@gmail.com