Skip to content

updated badges and fixed deprecation warnings #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

updated badges and fixed deprecation warnings #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be1dc78
updated badges and fixed deprecation warnings
berndpfrommer Mar 7, 2025
1ce0d59
only use AV_FRAME_FLAG_KEY when available
berndpfrommer Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ To extract e.g. frames or an mp4 file from a recorded bag, have a look at the
Continuous integration is tested under Ubuntu with the following ROS2 distros:

[![Build Status](https://build.ros2.org/buildStatus/icon?job=Hdev__ffmpeg_image_transport__ubuntu_jammy_amd64&subject=Humble)](https://build.ros2.org/job/Hdev__ffmpeg_image_transport__ubuntu_jammy_amd64/)
[![Build Status](https://build.ros2.org/buildStatus/icon?job=Idev__ffmpeg_image_transport__ubuntu_jammy_amd64&subject=Iron)](https://build.ros2.org/job/Idev__ffmpeg_image_transport__ubuntu_jammy_amd64/)
[![Build Status](https://build.ros2.org/buildStatus/icon?job=Rdev__ffmpeg_image_transport__ubuntu_jammy_amd64&subject=Rolling)](https://build.ros2.org/job/Rdev__ffmpeg_image_transport__ubuntu_jammy_amd64/)
[![Build Status](https://build.ros2.org/buildStatus/icon?job=Jdev__ffmpeg_image_transport__ubuntu_noble_amd6464&subject=Jazzy)](https://build.ros2.org/job/Jdev__ffmpeg_image_transport__ubuntu_noble_amd64/)
[![Build Status](https://build.ros2.org/buildStatus/icon?job=Rdev__ffmpeg_image_transport__ubuntu_noble_amd64&subject=Rolling)](https://build.ros2.org/job/Rdev__ffmpeg_image_transport__ubuntu_noble_amd64/)


## Installation
Expand Down
8 changes: 7 additions & 1 deletion src/ffmpeg_decoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,13 @@ bool FFMPEGDecoder::decodePacket(const FFMPEGPacketConstPtr & msg)
image->header = msg->header;
image->header.stamp = it->second;
ptsToStamp_.erase(it);
callback_(image, decodedFrame_->key_frame == 1); // deliver callback
// deliver callback
#ifdef AV_FRAME_FLAG_KEY
const bool isKeyFrame = (decodedFrame_->flags & AV_FRAME_FLAG_KEY) != 0;
#else
const bool isKeyFrame = decodedFrame_->key_frame == 1;
#endif
callback_(image, isKeyFrame);
}
}
av_packet_unref(packet);
Expand Down