Skip to content

Commit 7c5d0de

Browse files
Increase Readability of testing. (#5190)
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
1 parent c7589c9 commit 7c5d0de

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

nav2_mppi_controller/test/parameter_handler_test.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,24 +119,24 @@ TEST(ParameterHandlerTest, PrePostDynamicCallbackTest)
119119
TEST(ParameterHandlerTest, GetSystemParamsTest)
120120
{
121121
auto node = std::make_shared<rclcpp_lifecycle::LifecycleNode>("my_node");
122-
node->declare_parameter("test.param1", rclcpp::ParameterValue(true));
123-
node->declare_parameter("ns.test.param2", rclcpp::ParameterValue(7));
122+
std::string name = "test";
123+
node->declare_parameter("param1", rclcpp::ParameterValue(true));
124+
node->declare_parameter(name + ".param2", rclcpp::ParameterValue(7));
124125

125126
// Get parameters in global namespace and in subnamespaces
126-
std::string name = "test";
127127
ParametersHandler handler(node, name);
128128
auto getParameter = handler.getParamGetter("");
129129
bool p1 = false;
130130
int p2 = 0;
131-
getParameter(p1, "test.param1", false);
132-
getParameter(p2, "ns.test.param2", 0);
131+
getParameter(p1, "param1", false);
132+
getParameter(p2, name + ".param2", 0);
133133
EXPECT_EQ(p1, true);
134134
EXPECT_EQ(p2, 7);
135135

136136
// Get parameters in subnamespaces using name semantics of getter
137-
auto getParameter2 = handler.getParamGetter("ns");
137+
auto getParameter2 = handler.getParamGetter(name);
138138
p2 = 0;
139-
getParameter2(p2, "test.param2", 0);
139+
getParameter2(p2, "param2", 0);
140140
EXPECT_EQ(p2, 7);
141141
}
142142

0 commit comments

Comments
 (0)