-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add footprintAreaCost #5250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tonynajjar
wants to merge
6
commits into
ros-navigation:main
from
angsa-robotics:footprintAreaCost-main
Closed
Add footprintAreaCost #5250
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
876414a
Add footprintAreaCost
tonynajjar 4f2c5c4
remove include
tonynajjar 12829b5
Merge branch 'main' into footprintAreaCost-main
tonynajjar 5ff1628
fix footprintAreaCost
tonynajjar 1b64f15
remove isRectangularFootprint
tonynajjar db0fed4
fix formatting
tonynajjar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,9 +135,7 @@ bool GridCollisionChecker::inCollision( | |
return true; | ||
} | ||
|
||
// if possible inscribed, need to check actual footprint pose. | ||
// Use precomputed oriented footprints are done on initialization, | ||
// offset by translation value to collision check | ||
// Use full area checking instead of edge-only checking | ||
double wx, wy; | ||
costmap_->mapToWorld(static_cast<double>(x), static_cast<double>(y), wx, wy); | ||
geometry_msgs::msg::Point new_pt; | ||
|
@@ -150,7 +148,8 @@ bool GridCollisionChecker::inCollision( | |
current_footprint.push_back(new_pt); | ||
} | ||
|
||
float footprint_cost = static_cast<float>(footprintCost(current_footprint)); | ||
// Check full area covered by footprint | ||
float footprint_cost = static_cast<float>(footprintAreaCost(current_footprint)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can be parametrized to allow user to tune for speed vs accuracy |
||
|
||
if (footprint_cost == UNKNOWN_COST && traverse_unknown) { | ||
return false; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taken from collision_monitor. Libraries also exist for this e.g boost