both timers support up to 4 alarms #925
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
reviewed
May 8, 2025
|
If there are only four alarms for each timer, we only need a single AtomicU8, right? Whilst we're here, I think we can use https://doc.rust-lang.org/std/sync/atomic/struct.AtomicU8.html#method.fetch_and instead of a critical section. |
thejpster
force-pushed
the
feature/4_alarms_for_both_timers
branch
from
1ffc6c4 to
cb0bc7e
Compare
|
Updated to use CAS operations. Needs a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in previous version, there was possibility to have 2 timers but only 4 alarms total, here are changes, that makes possible to configure up to 4 alarms for each timer