prevent race condition that incorrectly redirects to the default tab som... #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please take a look at the latest in If you're happy with this it'll get into master and released. |
|
Looks good to me! |
|
Ok i've changed my approach - i've removed the default route change code entirely. If people want to deep-link they can link directly to the tab-selected routes. Landed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...etimes
Attempts to fix #15
This breaks the unit test
it('should route to the first entry in tabConfiguration array by default'...)but the my app and the example app both appear to work correctly with the change. I'm not sure how to fix the test: it seems events fire differently in a regular browser?