fix(postcss-hover-classes): avoid large regex overflow by filtering selectors #1681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the old
postcss-hover-classes
plugin, large stylesheets with many:hover
selectors caused the following error:This is reported in #1675.
Solution
This PR rewrites the plugin logic with the following improvements:
:hover
selectors before applying replacementsWeakSet
to ensure we only process each rule onceThis not only solves the regex overflow issue but also improves memory efficiency and overall performance when processing large stylesheets.
Related Issue
Closes #1675