Skip to content

fix(postcss-hover-classes): avoid large regex overflow by filtering selectors #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EricLLLLLL
Copy link

Problem

When using the old postcss-hover-classes plugin, large stylesheets with many :hover selectors caused the following error:

Regular expression too large

This is reported in #1675.


Solution

This PR rewrites the plugin logic with the following improvements:

  • Filters out only :hover selectors before applying replacements
  • Uses a WeakSet to ensure we only process each rule once
  • Avoids unnecessary string operations and large regex inputs

This not only solves the regex overflow issue but also improves memory efficiency and overall performance when processing large stylesheets.


Related Issue

Closes #1675

Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 331a9e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Playing Error : :hover/g: Regular expression too large
1 participant