This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Add the list of supported libp2p protocols to /id#381
Draft
ljedrz wants to merge 1 commit into
Draft
Conversation
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
commented
Sep 18, 2020
| _: &mut impl PollParameters, | ||
| params: &mut impl PollParameters, | ||
| ) -> Poll<NetworkBehaviourAction> { | ||
| if params.supported_protocols().len() != self.protocols.len() { |
Member
Author
There was a problem hiding this comment.
PollParameters::supported_protocols returns an ExactSizeIterator, so obtaining the len is cheap; this implementation assumes that the protocols could change during the node's lifetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the changes in
go-ipfsandjs-ipfs(and already required in the upstream conformance tests), this PR adds the quite useful list of supportedlibp2pprotocols to the JSON returned by/id.Since I'm not sure about the resulting small API changes and the way the protocols get populated (which was WAY harder than anticipated), I'm marking it as a draft.