Skip to content

Commit 2cea863

Browse files
alexmalyshevlehecka
authored andcommitted
Lint fixes for yarpl (#420)
1 parent a9bc269 commit 2cea863

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

experimental/yarpl/include/yarpl/Observable.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class Observable : public virtual Refcounted {
6565
template <typename OnSubscribe>
6666
class FromPublisherOperator : public Observable<T> {
6767
public:
68-
FromPublisherOperator(OnSubscribe&& function)
68+
explicit FromPublisherOperator(OnSubscribe&& function)
6969
: function_(std::move(function)) {}
7070

7171
void subscribe(Reference<Observer<T>> subscriber) override {

experimental/yarpl/include/yarpl/Refcounted.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class Reference {
8181
inc();
8282
}
8383

84-
Reference(Reference&& other) : pointer_(other.pointer_) {
84+
Reference(Reference&& other) noexcept : pointer_(other.pointer_) {
8585
other.pointer_ = nullptr;
8686
}
8787

experimental/yarpl/include/yarpl/flowable/FlowableOperator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ class SubscribeOnOperator : public FlowableOperator<T, T> {
247247
template <typename T, typename OnSubscribe>
248248
class FromPublisherOperator : public Flowable<T> {
249249
public:
250-
FromPublisherOperator(OnSubscribe&& function)
250+
explicit FromPublisherOperator(OnSubscribe&& function)
251251
: function_(std::move(function)) {}
252252

253253
void subscribe(Reference<Subscriber<T>> subscriber) override {

experimental/yarpl/include/yarpl/observable/ObservableOperator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class SubscribeOnOperator : public ObservableOperator<T, T> {
224224
template <typename T, typename OnSubscribe>
225225
class FromPublisherOperator : public Observable<T> {
226226
public:
227-
FromPublisherOperator(OnSubscribe&& function)
227+
explicit FromPublisherOperator(OnSubscribe&& function)
228228
: function_(std::move(function)) {}
229229

230230
void subscribe(Reference<Observer<T>> subscriber) override {

experimental/yarpl/include/yarpl/observable/Observers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class Observers {
7373
template <typename T, typename Next>
7474
class Base : public Observer<T> {
7575
public:
76-
Base(Next&& next)
76+
explicit Base(Next&& next)
7777
: next_(std::forward<Next>(next)) {}
7878

7979
void onNext(T value) override {

experimental/yarpl/test/Observable_test.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,8 @@ TEST(Observable, DISABLED_SimpleTake) {
383383
}
384384

385385
TEST(Observable, Error) {
386-
auto observable = Observables::error<int>(std::runtime_error("something broke!"));
386+
auto observable =
387+
Observables::error<int>(std::runtime_error("something broke!"));
387388
auto collector = make_ref<CollectingObserver<int>>();
388389
observable->subscribe(collector);
389390

0 commit comments

Comments
 (0)