Skip to content

Commit f8bd469

Browse files
committed
Remove inst/json, point docs to web links instead
The inclusion of these files tipped us over the 5Mb threshold which triggers CRAN's scrutiny.
1 parent e28b091 commit f8bd469

File tree

9 files changed

+15
-144
lines changed

9 files changed

+15
-144
lines changed

cran-comments.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,8 @@
11
## Comments
22

3-
#### 2019-11-08
4-
5-
This submission is done to correct a testing issue with `scales`.
6-
7-
This submission is done by Barret Schloerke <barret@rstudio.com> on behalf of Joe Cheng <joe@rstudio.com>. Please submit any changes to be made to <barret@rstudio.com>.
8-
9-
- Barret
3+
#### 2022-02-15
104

5+
This submission is at Dr. Ripley's request; it fixes some unit tests that broke with a recent update to sf.
116

127
## Test environments
138

@@ -17,7 +12,7 @@ This submission is done by Barret Schloerke <barret@rstudio.com> on behalf of Jo
1712
* ubuntu 14.04.5 (on travis-ci), R version 3.6.1 (2017-01-27)
1813
* 0 errors | 0 warnings | 0 notes
1914

20-
* win-builder (oldrelease, release, and devel)
15+
* win-builder (devel)
2116
* 0 errors | 0 warnings | 0 notes
2217

2318
* R-hub windows-x86_64-devel (r-devel)
@@ -34,7 +29,7 @@ This submission is done by Barret Schloerke <barret@rstudio.com> on behalf of Jo
3429

3530
## revdepcheck results
3631

37-
We checked 95 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
32+
We checked 151 reverse dependencies (145 from CRAN + 6 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package.
3833

39-
* We saw 0 new problems
40-
* We failed to check 0 packages
34+
* We saw 0 new problems
35+
* We failed to check 0 packages

docs/choropleths.Rmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ library(magrittr)
1515

1616
```{r fig.height = 4.75, echo = FALSE}
1717
# From http://leafletjs.com/examples/choropleth/us-states.js
18-
states <- geojsonio::geojson_read(system.file("json/us-states.geojson", package="leaflet"), what = "sp")
18+
states <- geojsonio::geojson_read("https://rstudio.github.io/leaflet/json/us-states.geojson", what = "sp")
1919
2020
bins <- c(0, 10, 20, 50, 100, 200, 500, 1000, Inf)
2121
pal <- colorBin("YlOrRd", domain = states$density, bins = bins)
@@ -59,7 +59,7 @@ We'll start by loading the data from JSON. While the Leaflet.js example loads th
5959
In this case, we'll use the `geojsonio` package to load the data into `sp` objects, which will let us easily manipulate the geographic features, and their properties, in R.
6060

6161
```{r}
62-
states <- geojsonio::geojson_read(system.file("json/us-states.geojson", package="leaflet"), what = "sp")
62+
states <- geojsonio::geojson_read("https://rstudio.github.io/leaflet/json/us-states.geojson", what = "sp")
6363
class(states)
6464
names(states)
6565
```
@@ -181,7 +181,7 @@ m %>% addLegend(pal = pal, values = ~density, opacity = 0.7, title = NULL,
181181

182182
```{r results = 'hide'}
183183
# From http://leafletjs.com/examples/choropleth/us-states.js
184-
states <- geojsonio::geojson_read(system.file("json/us-states.geojson", package="leaflet"), what = "sp")
184+
states <- geojsonio::geojson_read("https://rstudio.github.io/leaflet/json/us-states.geojson", what = "sp")
185185
186186
bins <- c(0, 10, 20, 50, 100, 200, 500, 1000, Inf)
187187
pal <- colorBin("YlOrRd", domain = states$density, bins = bins)

docs/colors.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ The `domain` argument tells the color function the range of input values. You ca
4444
library(rgdal)
4545
4646
# From http://data.okfn.org/data/datasets/geo-boundaries-world-110m
47-
countries <- readOGR(system.file("json/countries.geojson", package="leaflet"))
47+
countries <- readOGR("https://rstudio.github.io/leaflet/json/countries.geojson")
4848
map <- leaflet(countries)
4949
```
5050

docs/json.Rmd

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ library(magrittr)
1818
```{r message=FALSE,warning=FALSE}
1919
# From http://eric.clst.org/Stuff/USGeoJSON and
2020
# https://en.wikipedia.org/wiki/List_of_United_States_counties_and_county_equivalents
21-
nycounties <- rgdal::readOGR(system.file("json/nycounties.geojson", package="leaflet"))
21+
nycounties <- rgdal::readOGR("https://rstudio.github.io/leaflet/json/nycounties.geojson")
2222
# Or use the geojsonio equivalent:
23-
# nycounties <- geojsonio::geojson_read(system.file("json/nycounties.geojson", package="leaflet"), what = "sp")
23+
# nycounties <- geojsonio::geojson_read("https://rstudio.github.io/leaflet/json/nycounties.geojson", what = "sp")
2424
2525
pal <- colorNumeric("viridis", NULL)
2626
@@ -46,7 +46,7 @@ Note that for larger JSON data, using parsed is significantly slower than using
4646
A simple example using stringified data:
4747

4848
```{r}
49-
topoData <- readLines(system.file("json/us-10m.json", package="leaflet")) %>% paste(collapse = "\n")
49+
topoData <- readLines("https://rstudio.github.io/leaflet/json/us-10m.json") %>% paste(collapse = "\n")
5050
5151
leaflet() %>% setView(lng = -98.583, lat = 39.833, zoom = 3) %>%
5252
addTiles() %>%
@@ -74,7 +74,7 @@ library(jsonlite, quietly = TRUE)
7474
library(jsonlite)
7575
7676
# From http://data.okfn.org/data/datasets/geo-boundaries-world-110m
77-
geojson <- readLines(system.file("json/countries.geojson", package="leaflet"), warn = FALSE) %>%
77+
geojson <- readLines("https://rstudio.github.io/leaflet/json/countries.geojson", warn = FALSE) %>%
7878
paste(collapse = "\n") %>%
7979
fromJSON(simplifyVector = FALSE)
8080

docs/legends.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ library(magrittr)
1515
library(rgdal)
1616
1717
# From http://data.okfn.org/data/datasets/geo-boundaries-world-110m
18-
countries <- readOGR(system.file("json/countries.geojson", package="leaflet"))
18+
countries <- readOGR("https://rstudio.github.io/leaflet/json/countries.geojson")
1919
map <- leaflet(countries) %>% addTiles()
2020
```
2121

inst/json/countries.geojson

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)