Skip to content

Commit f9ae6df

Browse files
gadenbuiegadenbuie
committed
chore: Final revdepcheck and CRAN comments
1 parent dc550ea commit f9ae6df

File tree

5 files changed

+66
-118
lines changed

5 files changed

+66
-118
lines changed

‎cran-comments.md

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,18 @@
11
## Comments
22

3-
#### 2023-03-10
4-
5-
Fixing S3 method warnings for R Devel prompted by Kurt.
6-
7-
Please let me know if I can provide any more information.
8-
9-
Thank you,
10-
Joe
11-
12-
## Test environments
13-
14-
* local macOS, R 4.2
15-
* GitHub Actions
16-
* macOS
17-
* 4.2
18-
* windows
19-
* 4.2
20-
* ubuntu20
21-
* devel, 4.2, 4.1, 4.0, 3.6, 3.5
22-
* devtools::
23-
* check_win_devel()
24-
25-
## R CMD check results
26-
27-
0 errors ✔ | 0 warnings ✔ | 0 notes ✔
3+
This release removes dependencies on rgdal and rgeos, in addition to other general improvements and bug fixes.
284

5+
Please let us know if we can provide any more information.
296

307
## revdepcheck results
318

32-
We checked 159 reverse dependencies (158 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
9+
We checked 165 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
3310

34-
* We saw 0 new problems
35-
* We failed to check 1 package
11+
* We saw 1 new problems
12+
* We failed to check 0 packages
3613

3714
Issues with CRAN packages are summarised below.
3815

39-
### Failed to check
16+
### New problems
4017

41-
* geocmeans (NA)
18+
* leaflet.opacity: We provided a fix to the maintainer in a pull request on 2023-08-15 (https://github.com/be-marc/leaflet.opacity/pull/3).

‎revdep/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Revdeps
22

3-
## Failed to check (1)
3+
## New problems (1)
4+
5+
|package |version |error |warning |note |
6+
|:---------------|:-------|:------|:-------|:----|
7+
|[leaflet.opacity](problems.md#leafletopacity)|0.1.0 |__+1__ | |1 |
48

5-
|package |version |error |warning |note |
6-
|:---------|:-------|:-----|:-------|:----|
7-
|geocmeans |? | | | |

‎revdep/cran.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
## revdepcheck results
22

3-
We checked 159 reverse dependencies (158 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 165 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
44

5-
- We saw 0 new problems
6-
- We failed to check 2 packages
5+
* We saw 1 new problems
6+
* We failed to check 0 packages
77

88
Issues with CRAN packages are summarised below.
99

10-
### Failed to check
10+
### New problems
11+
(This reports the first line of each new failure)
12+
13+
* leaflet.opacity
14+
checking tests ... ERROR
1115

12-
- fitbitViz (NA)
13-
- geocmeans (NA)

‎revdep/failures.md

Lines changed: 1 addition & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -1,77 +1 @@
1-
# geocmeans
2-
3-
<details>
4-
5-
- Version: 0.3.3
6-
- GitHub: https://github.com/JeremyGelb/geocmeans
7-
- Source code: https://github.com/cran/geocmeans
8-
- Date/Publication: 2023-02-07 01:02:31 UTC
9-
- Number of recursive dependencies: 197
10-
11-
Run `revdepcheck::cloud_details(, "geocmeans")` for more info
12-
13-
</details>
14-
15-
## Error before installation
16-
17-
### Devel
18-
19-
```
20-
* using log directory ‘/tmp/workdir/geocmeans/new/geocmeans.Rcheck’
21-
* using R version 4.1.1 (2021-08-10)
22-
* using platform: x86_64-pc-linux-gnu (64-bit)
23-
* using session charset: UTF-8
24-
* using option ‘--no-manual’
25-
* checking for file ‘geocmeans/DESCRIPTION’ ... OK
26-
* checking extension type ... Package
27-
* this is package ‘geocmeans’ version ‘0.3.3’
28-
* package encoding: UTF-8
29-
* checking package namespace information ... OK
30-
...
31-
--- finished re-building ‘rasters.Rmd’
32-
33-
SUMMARY: processing the following file failed:
34-
‘introduction.Rmd’
35-
36-
Error: Vignette re-building failed.
37-
Execution halted
38-
39-
* DONE
40-
Status: 2 ERRORs, 1 WARNING, 1 NOTE
41-
42-
43-
44-
45-
46-
```
47-
48-
### CRAN
49-
50-
```
51-
* using log directory ‘/tmp/workdir/geocmeans/old/geocmeans.Rcheck’
52-
* using R version 4.1.1 (2021-08-10)
53-
* using platform: x86_64-pc-linux-gnu (64-bit)
54-
* using session charset: UTF-8
55-
* using option ‘--no-manual’
56-
* checking for file ‘geocmeans/DESCRIPTION’ ... OK
57-
* checking extension type ... Package
58-
* this is package ‘geocmeans’ version ‘0.3.3’
59-
* package encoding: UTF-8
60-
* checking package namespace information ... OK
61-
...
62-
--- finished re-building ‘rasters.Rmd’
63-
64-
SUMMARY: processing the following file failed:
65-
‘introduction.Rmd’
66-
67-
Error: Vignette re-building failed.
68-
Execution halted
69-
70-
* DONE
71-
Status: 2 ERRORs, 1 WARNING, 1 NOTE
72-
73-
74-
75-
76-
77-
```
1+
*Wow, no problems at all. :)*

‎revdep/problems.md

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,45 @@
1-
*Wow, no problems at all. :)*
1+
# leaflet.opacity
2+
3+
<details>
4+
5+
* Version: 0.1.0
6+
* GitHub: https://github.com/be-marc/leaflet.opacity
7+
* Source code: https://github.com/cran/leaflet.opacity
8+
* Date/Publication: 2018-11-29 16:00:10 UTC
9+
* Number of recursive dependencies: 80
10+
11+
Run `revdepcheck::cloud_details(, "leaflet.opacity")` for more info
12+
13+
</details>
14+
15+
## Newly broken
16+
17+
* checking tests ... ERROR
18+
```
19+
Running ‘testthat.R’
20+
Running the tests in ‘tests/testthat.R’ failed.
21+
Last 13 lines of output:
22+
y[1]: "opacity"
23+
── Failure ('test-controls.R:52:3'): Initialize map dependencies in addHigherOpacity ──
24+
res$dependencies[[1]]$name not equal to "jquery-ui".
25+
1/1 mismatches
26+
x[1]: "jquery"
27+
y[1]: "jquery-ui"
28+
── Failure ('test-controls.R:53:3'): Initialize map dependencies in addHigherOpacity ──
29+
res$dependencies[[2]]$name not equal to "opacity".
30+
1/1 mismatches
31+
x[1]: "leaflet"
32+
y[1]: "opacity"
33+
34+
[ FAIL 6 | WARN 4 | SKIP 0 | PASS 3 ]
35+
Error: Test failures
36+
Execution halted
37+
```
38+
39+
## In both
40+
41+
* checking LazyData ... NOTE
42+
```
43+
'LazyData' is specified without a 'data' directory
44+
```
45+

0 commit comments

Comments
 (0)