Skip to content

write to log-file immediatly on every log#378

Merged
hannesgredler merged 1 commit intortbrick:devfrom
jcpvdm:logfile-fflush
Apr 3, 2026
Merged

write to log-file immediatly on every log#378
hannesgredler merged 1 commit intortbrick:devfrom
jcpvdm:logfile-fflush

Conversation

@jcpvdm
Copy link
Copy Markdown
Contributor

@jcpvdm jcpvdm commented Mar 14, 2026

This helps tracking current state of events when running bngblaster in the background like this:
bngblaster -L log -C blaster.json &> /dev/null &

Before this patch, logs were buffered and not written immediately.

@hannesgredler
Copy link
Copy Markdown
Member

I'd rather not do this as it will kill performance for hot logging environments. What i'd do instead is to start a periodic timer (100ms) that calls into fflush(); That way you can tune how much delay you want to accept.

@jcpvdm
Copy link
Copy Markdown
Contributor Author

jcpvdm commented Mar 15, 2026

sounds good @hannesgredler. Perhaps this PR can be closed and you add a commit using the timer method?

@jcpvdm
Copy link
Copy Markdown
Contributor Author

jcpvdm commented Apr 3, 2026

@hannesgredler, I have redone it using timer following your suggestion, can you have a look?

@hannesgredler hannesgredler merged commit a76e904 into rtbrick:dev Apr 3, 2026
3 checks passed
@hannesgredler
Copy link
Copy Markdown
Member

Looks good - very nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants