Type annotations #127

JaapJoris · 2025-07-22T20:17:51Z

Here is my attempt to add valid type annotations to DjHTML.

djhtml/modes.py

.pre-commit-config.yaml

djhtml/modes.py

This pattern was idiosyncratic and mypy doesn't like it.

…-commit run -a` If all goes well, this will cause the pipeline to complete successfully but fail with a pre-commit error, which the next commit will solve.

.github/workflows/main.yml

.pre-commit-config.yaml

djhtml/__main__.py

djhtml/modes.py

djhtml/options.py

djhtml/__main__.py

djhtml/lines.py

djhtml/modes.py

djhtml/options.py

JaapJoris added 2 commits July 22, 2025 22:10

Enable strict typing

4b54532

First batch of type fixes

836d079

JaapJoris self-assigned this Jul 22, 2025

JaapJoris added 3 commits July 23, 2025 18:33

Second batch of type fixes

7d9b58e

Third batch of type fixes

027f732

Fix Python 3.9 compatibility

9fdf70b

JaapJoris commented Jul 24, 2025

View reviewed changes

djhtml/modes.py Outdated Show resolved Hide resolved

JaapJoris added 2 commits July 26, 2025 12:08

Final batch of type fixes

ba7ec3b

Add mypy pre-commit hook

042e5c5

JaapJoris commented Jul 26, 2025

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

JaapJoris removed their assignment Jul 26, 2025

sjoerdjob reviewed Jul 28, 2025

View reviewed changes

JaapJoris added 13 commits July 28, 2025 16:56

Get rid of redundant options.pyi

b813040

Stop using self as the namespace for command-line arguments

79a366b

This pattern was idiosyncratic and mypy doesn't like it.

Add typing to test suite

a98222f

Run pre-commit run -a

85ae8b6

Unpin dependencies in pipeline to catch breakages early, and add `pre…

175684b

…-commit run -a` If all goes well, this will cause the pipeline to complete successfully but fail with a pre-commit error, which the next commit will solve.

Re-add @rev to workflow actions

851acff

Prevent workflow jobs from running twice

3965037

Upgrade pre-commit hooks

ae31e87

Improve typing of class variables

a17d1e4

Improve typing off places that use OffsetDict

6965313

Rename _Base to BaseToken

79400bc

Write out all arguments to __init__() explicitly

6f9390c

Convert extra_blocks to dict[str, str] at an earlier stage

0401c49