Skip to content

Commit bcc6704

Browse files
committed
nits: Move to generate_ldflags
1 parent c808eda commit bcc6704

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

_gem/lib/go_gem/rake_task.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ def self.build_env_vars
110110
cflags.gsub!("-Wsuggest-attribute=format", "")
111111
cflags.gsub!("-Wold-style-definition", "")
112112
cflags.gsub!("-Wsuggest-attribute=noreturn", "")
113-
ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "")
114113
end
115114

116115
# FIXME: Workaround for Alpine

_gem/lib/go_gem/util.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ def self.generate_ldflags
2626
ldflags << " -undefined dynamic_lookup"
2727
end
2828

29+
# FIXME: Workaround for Ubuntu (GitHub Actions)
30+
ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "") if RUBY_PLATFORM =~ /linux/i
31+
2932
ldflags
3033
end
3134
end

0 commit comments

Comments
 (0)