-
Notifications
You must be signed in to change notification settings - Fork 28
[DOC] Doc for method #run #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You've been generating an overwhelming amount of notifications for making the same kind of changes, documentation. Can you prepare all documentation changes you want in ERB first, and then batch all those changes in this single PR? As long as different changes are made in different commits, I can "Rebase and merge" it to preserve the commit history. If this is going to be your last PR to ERB, I can just merge it as is though. |
I
No, not my last PR to ERB. It's been my habit and preference (over at ruby/ruby and elsewhere, with reviewers @peterzhu2118, @jeremyevans, and others) to put up small PRs when possible; that lets us have one thread of discussion. (I'm primarily a documentor, not a developer, and I'm only moderately comfortable with git and github.) I'd like to continue small PRs here, but if you feel strongly I'll go large. Btw, I much appreciate your prompt reviews/merges. Very helpful in keeping me on track. |
|
Different repos have different maintainers who maintain things differently :) Yes, I feel strongly that I would rather not receive five notifications from you in a single day like yesterday for documenting a single gem. If we decide to make a lot of comments or threads for different parts, we could split them afterward. Alternatively, please file all PRs at once. I'm also fine if all these notifications come at the same time. You're forcing me a lot of context switches by sending many PRs with intervals. |
Okay, got it! |
|
@k0kubun, if I rename branch |
|
I don't think you can rename the branch associated to an already open PR, but if you want to close it and open another one once with a different branch name, I'm fine with it. |
No description provided.